Add tests for proposal-duplicate-named-capturing-groups #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
previously approved these changes
Aug 8, 2022
Comment on lines
+14
to
+24
| assert.compareArray( | ||
| Object.keys(regexp.exec("aa").groups), | ||
| ["y", "x"], | ||
| "property enumeration order of the groups object is based on source order, not match order" | ||
| ); | ||
|
|
||
| assert.compareArray( | ||
| Object.keys(regexp.exec("bb").groups), | ||
| ["y", "x"], | ||
| "property enumeration order of the groups object is based on source order, not match order" | ||
| ); |
There was a problem hiding this comment.
I'd like for these messages to be distinct, but I can't come up with clear replacements that are.
gibson042
approved these changes
Aug 8, 2022
ptomato
force-pushed
the
duplicate-named-capture-groups
branch
from
c290a35
to
5d3bd3c
Compare
|
Making a sweep of approved but unmerged PRs; feel free to follow up with an improvement to the assertion message if one occurs to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds simple tests for https://github.com/tc39/proposal-duplicate-named-capturing-groups, which achieved stage 3 at the July 2022 meeting. No existing tests were invalidated, but some needed their descriptions updated.