String.prototype.isWellFormed/String.prototype.toWellFormed: add tests
#3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/built-ins/String/prototype/isWellFormed/returns-boolean.js
Outdated
Show resolved
Hide resolved
test/built-ins/String/prototype/isWellFormed/returns-boolean.js
Outdated
Show resolved
Hide resolved
ljharb
force-pushed
the
well-formed
branch
5 times, most recently
from
9496643 to
e18488f
Compare
test/built-ins/String/prototype/isWellFormed/returns-boolean.js
Outdated
Show resolved
Hide resolved
michaelficarra
previously approved these changes
Sep 15, 2022
ljharb
added a commit
to es-shims/String.prototype.isWellFormed
that referenced
this pull request
Sep 15, 2022
ljharb
added a commit
to es-shims/String.prototype.toWellFormed
that referenced
this pull request
Sep 15, 2022
Ms2ger
previously requested changes
Sep 15, 2022
test/built-ins/String/prototype/isWellFormed/not-a-constructor.js
Outdated
Show resolved
Hide resolved
test/built-ins/String/prototype/isWellFormed/return-abrupt-from-this.js
Outdated
Show resolved
Hide resolved
test/built-ins/String/prototype/toWellFormed/returns-well-formed-string.js
Outdated
Show resolved
Hide resolved
test/built-ins/String/prototype/toWellFormed/returns-well-formed-string.js
Outdated
Show resolved
Hide resolved
ljharb
force-pushed
the
well-formed
branch
2 times, most recently
from
58e119d to
479afaa
Compare
ptomato
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
This proposal reached stage 3 today and this PR has had 2 reviews, one from a maintainer and one from the proposal champion. I think it's time to merge it, so this is a rubberstamp.
The linter seems to be complaining about a couple of files that don't have newlines at the end (https://app.circleci.com/pipelines/github/tc39/test262/4566/workflows/c2330ae2-25e9-4ecc-b925-4965328f5925/jobs/42689) but I think this should be all clear to merge after fixing that and rebasing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the stage 2 proposal https://github.com/tc39/proposal-is-usv-string.