Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve is/toWellFormedString coverage. #3755

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Improve is/toWellFormedString coverage. #3755

merged 1 commit into from
Dec 21, 2022

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 20, 2022

No description provided.

@Ms2ger Ms2ger requested a review from a team as a code owner December 20, 2022 16:53
ljharb added a commit to es-shims/String.prototype.isWellFormed that referenced this pull request Dec 20, 2022
@ljharb
[Tests] add more test coverage from tc39/test262#3755
9f9bf60
ljharb added a commit to es-shims/String.prototype.toWellFormed that referenced this pull request Dec 20, 2022
@ljharb
[Tests] add more test coverage from tc39/test262#3755
964ea7c
ljharb
ljharb approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, I added these same tests in my polyfills and they passed :-)

also thanks for catching those other mistakes

@Ms2ger Ms2ger merged commit 920a567 into main Dec 21, 2022
@Ms2ger Ms2ger deleted the usvstring branch December 21, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ms2ger @ljharb