Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Intl Locale API tests w/ PR67 #3797

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Sync Intl Locale API tests w/ PR67 #3797

merged 1 commit into from
Sep 13, 2023

Conversation

FrankYFTang
Copy link
Contributor

change the tests to sync with

tc39/proposal-intl-locale-info#67

@FrankYFTang FrankYFTang requested a review from a team as a code owner March 21, 2023 01:02
@FrankYFTang
Copy link
Contributor Author

@ryzokuken @sffc @romulocintra

@ptomato
Copy link
Contributor

ptomato commented May 31, 2023

@FrankYFTang I believe this is ready, and the normative change has consensus and has been merged. It looks like some output-array-values.js tests have been added in the meantime to some of the folders that this PR removes, though. Could you look at whether those need to be moved those to the new folders?

@CanadaHonk
Copy link
Member

This fixes #3746.

@FrankYFTang
Copy link
Contributor Author

rebased PTAL

@Ms2ger Ms2ger enabled auto-merge (rebase) September 13, 2023 13:59
@Ms2ger Ms2ger merged commit bba19d5 into tc39:main Sep 13, 2023
1 check passed
@ptomato ptomato mentioned this pull request Sep 13, 2023
Closed
@FrankYFTang FrankYFTang deleted the fixIntLocaleInfo branch September 13, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@gibson042 gibson042 Awaiting requested review from gibson042

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FrankYFTang @ptomato @CanadaHonk @Ms2ger @gibson042