Update temporalHelpers.js #3861
Conversation
justingrant
force-pushed
the
fix-temporal-helpers
branch
2 times, most recently
from
c766300
to
9f7d88a
Compare
There was a problem hiding this comment.
Fix SpecificOffsetTimeZone helper class so that it correctly implements the time zone protocol. Previously, some tests were passing but not actually exercising the expected codepaths.
I definitely intended the [] as a stub, because it hadn't been needed so far. Now that it's needed for the time zone offset tests, seems great to implement it 😄
Thanks!
| getPossibleInstantsFor() { | ||
| return []; | ||
| getPossibleInstantsFor(dt) { | ||
| if (typeof this._offsetValue !== 'number' || Math.abs(this._offsetValue) >= 86400e9 || isNaN(this._offsetValue)) return []; |
There was a problem hiding this comment.
I think if any of these conditions are true, the test helper is being misused ... but I don't mind having this here.
There was a problem hiding this comment.
If I remember correctly, I did it this way so that tests would fail in the right place in cases where the offset was invalid: either not a number or out of range. Otherwise, the failures would happen in the next line here in temporalHelpers, instead of actually exercising Temporal implementations' ability to reject invalid offset time zone IDs.
* Fix SpecificOffsetTimeZone so that it correctly implements the time zone protocol. Previously, tests were passing but not actually exercising the expected codepaths. * Add assertDateDuration function, which makes it shorter to assert durations that only contain date components.
ptomato
force-pushed
the
fix-temporal-helpers
branch
from
9f7d88a
to
460aa5c
Compare
SpecificOffsetTimeZonehelper class so that it correctly implements the time zone protocol. Previously, some tests were passing but not actually exercising the expected codepaths.assertDateDurationfunction, which makes it shorter to assert durations that only contain date components.