Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for tc39/proposal-iterator-helpers#281 #3869

Merged
merged 2 commits into from
Jul 13, 2023
Merged

add tests for tc39/proposal-iterator-helpers#281 #3869

merged 2 commits into from
Jul 13, 2023

Conversation

michaelficarra
Copy link
Member

No description provided.

@michaelficarra michaelficarra requested a review from a team as a code owner July 11, 2023 22:11
@michaelficarra michaelficarra mentioned this pull request Jul 11, 2023
Merged
ljharb
ljharb approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the new semantics and these tests pass on my implementation (and the tests fail without the new semantics)

@ljharb ljharb requested a review from a team July 11, 2023 23:05
@Ms2ger Ms2ger merged commit 550c111 into main Jul 13, 2023
1 check passed
@Ms2ger Ms2ger deleted the iterator-helpers-280 branch July 13, 2023 14:04
@michaelficarra michaelficarra mentioned this pull request Aug 7, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelficarra @ljharb @Ms2ger