Correct DurationFormat test #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expectation values for the formatToParts are incorrect.
A. The listFormat is consturcted with
6. Perform ! CreateDataPropertyOrThrow(lfOpts, "type", "unit").
so it should not have " and " in the string. Comparing with
(new Intl.ListFormat("en", {type: "unit"})).formatToParts(["a", "b",
"c"]) and
value in the format d and the expected values in the
DurationFormat/prototype/format directory
B. The localized unit values for "short" (and therefore default)
are incorrect. Comparing with the expected values in the
DurationFormat/prototype/format directory
|
@ryzokuken @romulocintra @ptomato @sffc but the expected values were set incorrectly in 3771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expectation values for the formatToParts are incorrect.
The listFormat is consturcted with
so it should not have " and " in the string. Comparing with (new Intl.ListFormat("en", {type: "unit"})).formatToParts(["a", "b", "c"]) and value in the format d and the expected values in the DurationFormat/prototype/format directory B. The localized unit values for "short" (and therefore default)
are incorrect. Comparing with the expected values in the
DurationFormat/prototype/format directory
Compare with the string output in
https://github.com/tc39/test262/blob/main/test/intl402/DurationFormat/prototype/format/style-long-en.js
(notice there are no " and " but only ", ".)
https://github.com/tc39/test262/blob/main/test/intl402/DurationFormat/prototype/format/style-short-en.js
(notice it is "ms", "μs" and "ns", and there are no " and " but only ", ".)
and
https://github.com/tc39/test262/blob/main/test/intl402/DurationFormat/prototype/format/style-default-en.js
(same as above)