Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use proper isConstructor check for recently added ArrayBuffer/SharedArrayBuffer tests #3882

Merged
merged 1 commit into from
Aug 25, 2023
Merged

use proper isConstructor check for recently added ArrayBuffer/SharedArrayBuffer tests #3882

merged 1 commit into from
Aug 25, 2023

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 24, 2023

This also allows these tests to be filtered out by "features".

@ljharb ljharb requested a review from a team as a code owner July 24, 2023 20:26
@ljharb ljharb changed the title use proper isConstructor check for nrecently added ArrayBufferr/SharedArrayBuffer tests use proper isConstructor check for recently added ArrayBuffer/SharedArrayBuffer tests Jul 24, 2023
Ms2ger
Ms2ger requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the isConstructor checks is fine, but could you explain why you're removing the 'prototype' checks? They don't seem to be obviously superseded by isConstructor.

@ljharb
Copy link
Member Author

ljharb commented Jul 25, 2023

They’re not particularly useful; isConstructor is sufficient, and we don’t check the prototype anywhere else.

@ljharb ljharb requested a review from Ms2ger August 23, 2023 16:02
@ljharb ljharb requested a review from a team August 23, 2023 16:02
@Ms2ger Ms2ger enabled auto-merge (rebase) August 25, 2023 13:28
@Ms2ger Ms2ger merged commit eb613f6 into main Aug 25, 2023
1 check passed
@Ms2ger Ms2ger deleted the nonconstructor branch August 25, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljharb @Ms2ger