Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Add new numbering system "kawi" and "nagm" #3883

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Normative: Add new numbering system "kawi" and "nagm" #3883

merged 1 commit into from
Jul 25, 2023

Conversation

FrankYFTang
Copy link
Contributor

Adding tests for tc39/ecma402#714

@FrankYFTang FrankYFTang requested a review from a team as a code owner July 25, 2023 04:25
@Ms2ger Ms2ger requested a review from ryzokuken July 25, 2023 06:51
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 25, 2023

Is this something that needs a feature flag? I suppose that would be painful.

@anba
Copy link
Contributor

anba commented Jul 25, 2023

We didn't add any feature flags for past updates to the list of numbering systems: #3572, #2669, #2554

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 25, 2023

Sounds good. @anba, do you want to check the code points? :)

@anba
Copy link
Contributor

anba commented Jul 25, 2023

All code points seem to match:

@Ms2ger Ms2ger enabled auto-merge (rebase) July 25, 2023 07:59
@Ms2ger Ms2ger merged commit 9437cab into tc39:main Jul 25, 2023
1 check passed
@FrankYFTang FrankYFTang deleted the patch-11 branch July 31, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@ryzokuken ryzokuken Awaiting requested review from ryzokuken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @Ms2ger @anba