Temporal: Audit of user code calls, part 3 #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2023
ptomato
force-pushed
the
user-code-calls-part-3
branch
from
742f71c to
feb36c0
Compare
ptomato
force-pushed
the
user-code-calls-part-3
branch
from
feb36c0 to
00b0dc0
Compare
cjtenny
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Looks great to me, with one issue and one question. I think the resolution to the former is simple and wouldn't need re-review - either re-adding the tests or not.
I did find some paths that weren't covered, but that's no reason to block this set of tests and make a 6000 line pair of PRs any longer - I'll add that further coverage in a separate PR since I wrote some of them already while reasoning if the paths were viable.
6000 lines between temporal and tests for part 3, how do you do it? 😵💫
test/built-ins/Temporal/Duration/prototype/add/nanoseconds-to-days-loop-indefinitely-2.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/PlainDate/prototype/since/order-of-operations.js
Show resolved
Hide resolved
… ZDT This allows removing several tests, as calendar.dateAdd() is no longer called in several places, and it's no longer possible to create a situation where BigInt arithmetic is observable in NanosecondsToDays.
This removes several loopholes where it was possible to return particular values from user calls that would cause infinite loops, or calculate zero-length days.
…ditions Repeat all the existing tests for no-op duration rounding operations, but with negative durations.
ptomato
force-pushed
the
user-code-calls-part-3
branch
from
3f4e2c2 to
d26e3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next part of #3897. These tests should provide coverage for tc39/proposal-temporal#2671. Best reviewed commit by commit.