Temporal: Tests for balancing units after rounding #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2023
Merged
cjtenny
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
These look good to me; they cover the changes in tc39/proposal-temporal#2571 and the bug that I found in the spec change didn't affect the tests - tests were correct for desired behavior, spec text had just one oops that's been fixed!
See tc39/proposal-temporal#2563 The old behaviour was encoded in one test in staging, but the behaviour of largestUnit in duration rounding has changed since that test was written. Therefore I'm assuming that toString() should've been updated when that happened.
In order to fix tc39/proposal-temporal#2563, we added invocations of BalanceDurationRelative after some invocations of RoundDuration. These cause observable calendar calls, which must be accounted for in some existing tests.
ptomato
force-pushed
the
temporal-2563-balance-after-round
branch
from
4fdda57
to
0523ef7
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains tests that cover normative changes to Temporal that reached consensus in May 2023.
Normative PR: tc39/proposal-temporal#2571