Temporal.Duration normalization tests, part 2 of 3 #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 tasks
ptomato
force-pushed
the
duration-normalize-part-2
branch
from
c9ccbc4
to
2448b3f
Compare
ptomato
force-pushed
the
duration-normalize-part-2
branch
from
cbf4da8
to
7e6df92
Compare
|
Added extra tests for the cases that @anba identified, in a fixup commit so it's easy to see what changed. I will squash it before merging. |
ptomato
force-pushed
the
duration-normalize-part-2
branch
from
7e6df92
to
9bbab02
Compare
anba
added a commit
to anba/test262
that referenced
this pull request
Jan 2, 2024
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in tc39#3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
anba
added a commit
to anba/test262
that referenced
this pull request
Jan 9, 2024
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in tc39#3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
ptomato
force-pushed
the
duration-normalize-part-2
branch
from
9bbab02
to
f444710
Compare
ptomato
pushed a commit
to ptomato/test262
that referenced
this pull request
Jan 17, 2024
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in tc39#3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
ptomato
pushed a commit
to ptomato/test262
that referenced
this pull request
Jan 22, 2024
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in tc39#3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
ptomato
force-pushed
the
duration-normalize-part-2
branch
from
9fb7763
to
60538bc
Compare
Ms2ger
approved these changes
Jan 30, 2024
ptomato
pushed a commit
to ptomato/test262
that referenced
this pull request
Jan 31, 2024
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in tc39#3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
ptomato
force-pushed
the
duration-normalize-part-2
branch
from
60538bc
to
04e26c6
Compare
|
Thanks for the review. Since yesterday I added some tests from @nicolo-ribaudo as well as some tests from @anba, which I've reviewed. So I think this is ready. I'll merge it at the same time as the proposal-temporal PR. |
Adapts or removes tests that relied on creating durations that are now out of range. Adds new tests for maximum in-range and minimum out-of-range durations.
NormalizedTimeDurationToDays can no longer loop indefinitely, because at a certain point we will hit the upper bound of MAX_SAFE_INTEGER, so rename the test to reflect that it can loop an arbitrary but limited number of times. Add a test for the RangeError condition in NormalizedTimeDurationToDays when the time zone calculates a day length that is not a safe integer number of nanoseconds. While editing these tests, rename them to match the current name of the AO and make sure the step numbers are up to date. (Normally I wouldn't care so much about that, but these tests can be pretty confusing so it's good to be able to refer to the spec text.)
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in tc39#3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
ptomato
force-pushed
the
duration-normalize-part-2
branch
from
04e26c6
to
701339e
Compare
ptomato
pushed a commit
that referenced
this pull request
Jan 31, 2024
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in #3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(stacked on top of #3957, will rebase as appropriate)This PR contains tests that cover a Temporal normative change that reached consensus in July 2023.
Normative PR: tc39/proposal-temporal#2727