Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async-from-sync test the iterator closes when .throw() is undefined #3976

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Async-from-sync test the iterator closes when .throw() is undefined #3976

merged 4 commits into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. Adjust existing tests to match new spec for async-from-sync iterators 

    Testing normative changes of ecma626 PR 2600
    @ioannad @ptomato
    ioannad authored and ptomato committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    de3cccd View commit details
    Browse the repository at this point in the history

  2. Test that async-from-sync iterator closes when throw is undefined. 

    These test paths from newly added call to IteratorClose in step 7.c of
 %AsyncFromSyncIteratorPrototype%.throw
as per normative changes of ecma626 PR 2600
    @ioannad @ptomato
    ioannad authored and ptomato committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5f9a5b9 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    @ioannad @ljharb @ptomato
    2 people authored and ptomato committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1f4a2b7 View commit details
    Browse the repository at this point in the history

  4. Refactoring tests to use the Async Helpers. 

    Addresses review comments
- https://github.com/tc39/test262/pull/3976/files#r1451071569
- https://github.com/tc39/test262/pull/3976/files#r1451075479
    @ioannad @ptomato
    ioannad authored and ptomato committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    216e3c3 View commit details
    Browse the repository at this point in the history