Test that the sync iterator that returns a rejected promise closes. #3990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannad
changed the title
ptomato
approved these changes
Jan 18, 2024
when a rejected promise is returned normally by the iterator. These tests correspond to this normative changes example: https://docs.google.com/presentation/d/1W9EJoWOvi6jU1A2bwyixzOceoP_ASAeaOYER3Zy9P00/edit#slide=id.g10c9207737d_0_31
This includes the test case mentioned in ecma262 issue comment: tc39/ecma262#1849 (comment) Also using yield* we can test the changes to AsyncFromSyncIteratorContinuation when called via .throw().
ptomato
force-pushed
the
async-from-sync-iterator-close-tests-next-rejected-promise
branch
from
2768020
to
09ca86b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the normative changes in tc39/ecma262#2600 for the last block of new steps in AsyncFromSyncIteratorContinuation.
These tests have been tested with this PR of engine262, which implements the normative changes.
3rd of 3 PRs that should finish addressing #3387 .