Temporal assertion message formatting #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Jan 22, 2024
harness/temporalHelpers.js
Outdated
| @@ -101,7 +103,7 @@ var TemporalHelpers = { | |||
| * the corresponding field in another Temporal.Duration. | |||
| */ | |||
| assertDurationsEqual(actual, expected, description = "") { | |||
| assert(expected instanceof Temporal.Duration, `${description} expected value should be a Temporal.Duration`); | |||
| assert(expected instanceof Temporal.Duration, `${description}: expected value should be a Temporal.Duration`); | |||
There was a problem hiding this comment.
Why not do the prefix dance here? Also e.g. assertInstantsEqual
There was a problem hiding this comment.
Thanks for catching that. I think I just overlooked them.
ptomato
force-pushed
the
temporal-formatting
branch
from
676baf6
to
ec87f6d
Compare
Adding colons in the appropriate places will make assertion failures easier to understand.
We stored Temporal.PlainDateTime.compare in a variable for convenience but then used Temporal.PlainDate.compare instead. The variable was actually intended to be used here. No change in functionality.
ptomato
force-pushed
the
temporal-formatting
branch
from
ec87f6d
to
68755f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to the formatting of assertion messages for the various Temporal types. This should make assertion failures easier to understand.