Update NumberFormat.prototype.useGrouping test for CLDR 45 #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should allow both |
ptomato
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
This has been open for quite a long time, so implementations have had time to adapt to CLDR 45. In general I prefer not to test against hardcoded internationalization output, but given the age of this PR I'll suggest that we just land it. If that causes problems for implementations that haven't adapted to the CLDR change, we can then do something more complicated to allow both variations.
In CLDR 45, in the en-IN locale, the compact thousands symbol changed from 'T' to 'K' after a survey was conducted in India: unicode-org/cldr@b8d4472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CLDR 45, in the en-IN locale, the compact thousands symbol changed from 'T' to 'K' after a survey was conducted in India:
unicode-org/cldr@b8d4472