Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for later base64 changes #4133

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Tests for later base64 changes #4133

merged 3 commits into from
Jul 10, 2024

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jul 8, 2024

Tests for tc39/proposal-arraybuffer-base64#60 and tc39/proposal-arraybuffer-base64#58, which got consensus after the proposal had achieved stage 3 based on user and implementer feedback.

Based on #3994 (which incidentally is ready).

@bakkot bakkot requested a review from a team as a code owner July 8, 2024 05:11
@ljharb ljharb requested a review from a team as a code owner July 8, 2024 16:31
Base automatically changed from base64-tests to main July 8, 2024 16:56
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "writes up to error" tests fail on my polyfill, so I'll review those after trying to fix my bug, but otherwise they look OK. omit-padding tests pass for me.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed, once i updated my implementation to match the updated spec, tests all pass.

@ljharb ljharb requested a review from a team July 8, 2024 18:04
ljharb added a commit to es-shims/es-arraybuffer-base64 that referenced this pull request Jul 8, 2024
@Ms2ger Ms2ger enabled auto-merge (squash) July 10, 2024 09:32
@Ms2ger Ms2ger merged commit 08e1aa8 into main Jul 10, 2024
8 checks passed
@Ms2ger Ms2ger deleted the more-base64 branch July 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants