Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAB: Integrate staging tests for the .keys method #4138

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

ioannad
Copy link
Contributor

@ioannad ioannad commented Jul 8, 2024

of Array.prototype and TypedArray.prototype

This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js

@ioannad ioannad requested a review from a team as a code owner July 8, 2024 22:59
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion for improvement.

@ptomato ptomato merged commit 97cf4fd into tc39:main Jul 16, 2024
8 checks passed
@ioannad ioannad deleted the RAB-test-method-keys branch July 26, 2024 16:05
ioannad added a commit to ioannad/test262 that referenced this pull request Jul 30, 2024
ptomato pushed a commit to ioannad/test262 that referenced this pull request Aug 6, 2024
ptomato pushed a commit that referenced this pull request Aug 6, 2024
* Import relevant files from #3888

* Removing parts in resizableArrayBufferUtils.js and adding it in includes,
while applying review changes from PRs for previously tested methods.

* Removes unnecessary .from calls, as suggested in previous PR review
comment: #4138 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants