Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAB: Adds missing Array.prototype.filter 'shrink' tests plus typesetting #4139

Merged
merged 2 commits into from
Jul 11, 2024
Merged

RAB: Adds missing Array.prototype.filter 'shrink' tests plus typesetting #4139

merged 2 commits into from
Jul 11, 2024

Conversation

ioannad
Copy link
Contributor

@ioannad ioannad commented Jul 9, 2024

Also renames ResizeBufferMidIteration to ResizeMidIteration.

@ioannad ioannad requested a review from a team as a code owner July 9, 2024 17:24
@ioannad ioannad changed the title Adds missing Array.prototype.filter 'shrink' tests plus typesetting RAB: Adds missing Array.prototype.filter 'shrink' tests plus typesetting Jul 9, 2024
ptomato
ptomato approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
The added shrink test for filter seems like the same explanation as the one you already added for forEach, re. HasProperty and out-of-bounds.

@ptomato ptomato force-pushed the RAB-add-missing-filter-tests branch from eebc585 to 1d5f050 Compare July 11, 2024 22:39
@ptomato ptomato merged commit 0ce0bd7 into tc39:main Jul 11, 2024
8 checks passed
@ioannad ioannad deleted the RAB-add-missing-filter-tests branch July 26, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ioannad @ptomato