Update firstDay tests to latest spec after PR 79 #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
changed the title
ptomato
approved these changes
Jul 10, 2024
Spec Changes merged tc39/proposal-intl-locale-info#79
trflynn89
reviewed
Jul 11, 2024
| @@ -50,6 +47,24 @@ const validFirstDayOfWeekOptions = [ | |||
| [6, "en-u-fw-sat"], | |||
| [7, "en-u-fw-sun"], | |||
| [0, "en-u-fw-sun"], | |||
| [true, "en-u-fw-true"], | |||
There was a problem hiding this comment.
@FrankYFTang is this one correct? IIRC true is dropped from canonical locales. And that's how v8, SpiderMonkey, and LibJS all behave:
> new Intl.Locale('en-u-fw-true').toString()
"en-u-fw"
> new Intl.Locale('en-u-fw-false').toString()
"en-u-fw-false"There was a problem hiding this comment.
I didn't see that in CanonicalizeUValue, where should I be looking for that behvaiour?
There was a problem hiding this comment.
It would fall under step 2, which defers to TR-35.
https://unicode.org/reports/tr35/#Canonical_Unicode_Locale_Identifiers
A unicode_locale_id has canonical syntax when:
- Any type or tfield value "true" is removed.
There was a problem hiding this comment.
ah... that is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec Changes merged
tc39/proposal-intl-locale-info#79