RAB: Integrate staging tests for the .reduce method #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…des, while adjusting usage of CollectValuesAndResize and applying review changes from PRs for previously tested methods.
ptomato
force-pushed
the
RAB-test-method-reduce
branch
from
ba5120c
to
2023900
Compare
ptomato
requested changes
Jul 24, 2024
test/built-ins/Array/prototype/reduceRight/resizable-buffer-grow-mid-iteration.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/reduce/resizable-buffer-grow-mid-iteration.js
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/reduce/resizable-buffer-shrink-mid-iteration.js
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/reduceRight/resizable-buffer-grow-mid-iteration.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/reduceRight/resizable-buffer-shrink-mid-iteration.js
Outdated
Show resolved
Hide resolved
test/built-ins/TypedArray/prototype/reduceRight/resizable-buffer.js
Outdated
Show resolved
Hide resolved
|
@ptomato oh oops! Thank you! |
Addresses review comments
|
@ioannad Could you rebase this please? I think the removals of the reduceRight files are causing merge conflicts, we want to make sure they stay in-tree when it's merged. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of Array.prototype and TypedArray.prototype
This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
This should be very similar to #4157 for
.reduceRight.