Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spaces instead of tabs #4159

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

sosukesuzuki
Copy link
Contributor

When we update tesst262 for WebKit, WebKit style checker warns for tabs (context: WebKit/WebKit#30940 ).

For consistency, I think we should use spaces instead of tabs.

@sosukesuzuki sosukesuzuki requested a review from a team as a code owner July 18, 2024 04:41
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while tabs are far superior and more accessible, clearly we overwhelmingly use spaces, and we should be consistent

@ljharb ljharb requested a review from a team July 18, 2024 04:58
@sosukesuzuki
Copy link
Contributor Author

Yes I agree with you, I personally don't care which one we use, but we need to be consistent.

Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly we shouldn't be inconsistent even within a single file

@Ms2ger Ms2ger merged commit d09ecdb into tc39:main Jul 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants