Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAB: Integrate staging tests for the .reverse method #4160

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

ioannad
Copy link
Contributor

@ioannad ioannad commented Jul 22, 2024

of Array.prototype and TypedArray.prototype

This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js

@ioannad ioannad requested a review from a team as a code owner July 22, 2024 15:29
…des,

while adjusting usage of CollectValuesAndResize and applying review changes
from PRs for previously tested methods.
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I was wondering if there's a possibility to test mid-iteration growing and shrinking. But I think there is not. There's no callback or argument conversion which we could use to resize the ArrayBuffer. There are property accesses on the TypedArray but you cannot redefine numeric property keys on a TypedArray. You could redefine length but that's not mid-iteration, it'd be essentially the same as what we're already testing.

@ptomato ptomato merged commit 18ebac8 into tc39:main Jul 24, 2024
8 checks passed
@ioannad
Copy link
Contributor Author

ioannad commented Jul 26, 2024

I was wondering if there's a possibility to test mid-iteration growing and shrinking. But I think there is not. There's no callback or argument conversion which we could use to resize the ArrayBuffer. There are property accesses on the TypedArray but you cannot redefine numeric property keys on a TypedArray. You could redefine length but that's not mid-iteration, it'd be essentially the same as what we're already testing.

@ptomato do you think we should open an issue to figure out how to write such tests?

@ioannad ioannad deleted the RAB-test-method-reverse branch July 26, 2024 16:07
@ptomato
Copy link
Contributor

ptomato commented Jul 26, 2024

I'm not sure it's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants