Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use const in for (of) loops so harness code can be used in environments that don't support that #4163

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

p-bakker
Copy link
Contributor

@p-bakker p-bakker commented Jul 23, 2024

In order to not fail because harness code fails to load due to using not-supported EcmaScript features while not needed

Relates to ##3032

@p-bakker p-bakker requested a review from a team as a code owner July 23, 2024 16:06
@p-bakker p-bakker changed the title Dont use const in for (of) loops, for when those aren't properly Dont use const in for (of) loops, for when those aren't properly supported Jul 23, 2024
@p-bakker p-bakker changed the title Dont use const in for (of) loops, for when those aren't properly supported Don't use const in for (of) loops so harness code can be used oin environments that don't support that Jul 23, 2024
@p-bakker p-bakker changed the title Don't use const in for (of) loops so harness code can be used oin environments that don't support that Don't use const in for (of) loops so harness code can be used in environments that don't support that Jul 23, 2024
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptomato ptomato merged commit 0a8622d into tc39:main Jul 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants