Make resizableArrayBufferUtils not depend on syntax that may not be supported #4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-bakker
changed the title
ljharb
reviewed
Jul 24, 2024
p-bakker
force-pushed
the
3022_dont_throw_on_unsupported_typed_array_types
branch
from
ed53e08
to
3b42b6c
Compare
ptomato
approved these changes
Jul 24, 2024
ptomato
force-pushed
the
3022_dont_throw_on_unsupported_typed_array_types
branch
from
3b42b6c
to
336115d
Compare
ljharb
reviewed
Jul 24, 2024
Comment on lines
+21
to
+24
| // Using new Function()(); instead of just 'class x extends Y' as to not bomb out when `class` isn't supported | ||
| const MyUint8Array = new Function('return class MyUint8Array extends Uint8Array {}')(); | ||
| const MyFloat32Array = new Function('return class MyFloat32Array extends Float32Array {}')(); | ||
| const MyBigInt64Array = new Function('return class MyBigInt64Array extends BigInt64Array {}')(); |
There was a problem hiding this comment.
is it ok that these exceptions aren't caught?
There was a problem hiding this comment.
Sigh, no, they are not. I'm sorry, juggling too many things at once and trying to rush it through, shouldn't have done that...
Will send an additional PR tomorrow... Sorry again for keeping you all occupied...
p-bakker
added a commit
to p-bakker/test262
that referenced
this pull request
Jul 25, 2024
Added catch to achieve the entire goal of the previous PR to prevent the harness from loading if 'class' syntax isn't supported
ptomato
pushed a commit
that referenced
this pull request
Jul 25, 2024
Added catch to achieve the entire goal of the previous PR to prevent the harness from loading if 'class' syntax isn't supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not fail because harness code fails to load due to using not-supported EcmaScript features while not needed
Relates to ##3032