Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error from #4164 #4167

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Jul 24, 2024

Function statements require a name.

See #4166

Function statements require a name.

See tc39#4166
@ptomato ptomato requested a review from a team as a code owner July 24, 2024 17:10
@ptomato
Copy link
Contributor Author

ptomato commented Jul 24, 2024

cc @p-bakker @anba

@linusg
Copy link
Member

linusg commented Jul 24, 2024

This is still not correct, these all assign the regular Function constructor.

harness/hidden-constructors.js Outdated Show resolved Hide resolved
harness/hidden-constructors.js Outdated Show resolved Hide resolved
harness/hidden-constructors.js Outdated Show resolved Hide resolved
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming suggestions are included

Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ptomato
Copy link
Contributor Author

ptomato commented Jul 24, 2024

Doh! Thanks for the corrections.

@ptomato ptomato merged commit 50b023e into tc39:main Jul 24, 2024
8 checks passed
@ptomato ptomato deleted the fix-hidden-constructors branch July 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants