Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAB: Integrate staging tests for the .slice method #4174

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

ioannad
Copy link
Contributor

@ioannad ioannad commented Jul 29, 2024

of Array.prototype and TypedArray.prototype

This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js

@ioannad ioannad requested a review from a team as a code owner July 29, 2024 23:53
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have coerced-start-shrink.js for the Array.prototype.slice?

We could also consider testing resizing during coercion of the end argument. Currently these tests only test what happens when coercion of the start argument resizes the buffer.

@ioannad
Copy link
Contributor Author

ioannad commented Aug 13, 2024

Should we also have coerced-start-shrink.js for the Array.prototype.slice?

We could also consider testing resizing during coercion of the end argument. Currently these tests only test what happens when coercion of the start argument resizes the buffer.

@ptomato I added the tests you suggested, and an additional resizable-buffer.js test file for Array.p.slice.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptomato ptomato merged commit 12307f5 into tc39:main Aug 14, 2024
8 checks passed
ioannad added a commit to syg/test262 that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants