-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAB: Integrate staging tests for the .slice method #4174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also have coerced-start-shrink.js
for the Array.prototype.slice?
We could also consider testing resizing during coercion of the end
argument. Currently these tests only test what happens when coercion of the start
argument resizes the buffer.
@ptomato I added the tests you suggested, and an additional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…des, while applying review changes from PRs for previously tested methods.
parallel to TypedArray.p.slice resizable-buffer.js
a2027ac
to
ed9a5e6
Compare
Removed file previously added by PR tc39#4174
of Array.prototype and TypedArray.prototype
This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js