Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAB: Integrate staging tests for the .subarray method #4177

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

ioannad
Copy link
Contributor

@ioannad ioannad commented Jul 30, 2024

of TypedArray.prototype

This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js

@ioannad ioannad requested a review from a team as a code owner July 30, 2024 00:11
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my comment on slice(), should we test what happens when the buffer is resized during coercion of the end argument?

@ioannad
Copy link
Contributor Author

ioannad commented Aug 15, 2024

@ptomato there were already some tests for 'end', so I changed the test file names to indicate this, but I also added more tests for 'end'.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptomato ptomato merged commit 224c5c3 into tc39:main Aug 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants