Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test/built-ins/RegExp/escape/initial-char-escape.js #4180

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix test/built-ins/RegExp/escape/initial-char-escape.js #4180

merged 1 commit into from
Jul 30, 2024

Conversation

sosukesuzuki
Copy link
Contributor

escaped 'a' is x61

@sosukesuzuki sosukesuzuki marked this pull request as ready for review July 30, 2024 05:29
@sosukesuzuki sosukesuzuki requested a review from a team as a code owner July 30, 2024 05:29
lahma
lahma approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered this same thing. With this fix I can get test cases passing as expected.

Ms2ger
Ms2ger approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds reasonable

@Ms2ger Ms2ger merged commit 616dcad into tc39:main Jul 30, 2024
8 checks passed
@sosukesuzuki sosukesuzuki deleted the fix-regexp-escape-tests branch July 30, 2024 08:22
@ljharb
Copy link
Member

ljharb commented Jul 30, 2024

thanks, great catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sosukesuzuki @ljharb @Ms2ger @lahma