Add test for asi between get/set field and generator
#4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
field-get-followed-by-generator-asi
branch
3 times, most recently
from
cc87cdf
to
e72230d
Compare
1 task
linusg
reviewed
Aug 7, 2024
.../statements/class/elements/syntax/valid/grammar-field-named-get-followed-by-generator-asi.js
Outdated
Show resolved
Hide resolved
|
Could you also add a set ASI test? |
|
Test case with |
|
cc @anba for a review since you fixed this in SM :) |
anba
approved these changes
Sep 2, 2024
.../statements/class/elements/syntax/valid/grammar-field-named-set-followed-by-generator-asi.js
Outdated
Show resolved
Hide resolved
Ms2ger
approved these changes
Sep 2, 2024
Ms2ger
changed the title
get field and generatorget/set field and generator
Co-authored-by: Linus Groh <mail@linusgroh.de>
…ield-named-set-followed-by-generator-asi.js Co-authored-by: André Bargull <andre.bargull@gmail.com>
Ms2ger
force-pushed
the
field-get-followed-by-generator-asi
branch
from
05836fc
to
2498057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both SpiderMonkey and TypeScript fail parsing this code. V8, Babel and ESLint all pass the test.