Temporal: Add additional coverage based on issues reported by Anba #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
reviewed
Oct 4, 2024
...ntl402/Temporal/Instant/prototype/toLocaleString/default-includes-time-not-time-zone-name.js
Outdated
Show resolved
Hide resolved
| const plainTime = new Temporal.PlainTime(12, 23, 37, 847); | ||
|
|
||
| const dateStyleFormatter = new Intl.DateTimeFormat(undefined, { dateStyle: "short", calendar: "iso8601", timeZone: "America/Vancouver" }); | ||
| const dateStyleResult = JSON.stringify(dateStyleFormatter.formatRangeToParts(legacyDate, legacyDate)); |
There was a problem hiding this comment.
Is the serialization order guaranteed (or reliable enough?)
There was a problem hiding this comment.
It's "ascending chronological order of property creation" and the order in which type, value, and source are created is specified, so I think we're good.
...l402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-not-overlapping-options.js
Outdated
Show resolved
Hide resolved
ptomato
force-pushed
the
temporal-coverage
branch
from
b219fbb
to
304e7a5
Compare
27 tasks
…ntifiers This was an area missing test coverage.
Syntax is validated first. Only after the property bag is fully converted into a Calendar Fields Record does the calendar validate whether the month code actually exists in the year. See tc39/proposal-temporal#2962
…lity Syntax is validated first. Only after the property bag is fully converted into a Calendar Fields Record does the time zone validate whether the UTC offset is correct for that exact time in the time zone. See tc39/proposal-temporal#2962
…one component
Adds a test for each Temporal object's toLocaleString() method, formatting
them with only one option e.g. { year: 'numeric' } and comparing it with
the corresponding output for legacy Date.
See tc39/proposal-temporal#2796.
For each Temporal object, add tests for what components are present by default if no options for date or time components are passed.
These staging tests are incorrect. See tc39/proposal-temporal#2795. This was an unintended behaviour. It differed from the behaviour for dateStyle and timeStyle, which was the intended behaviour.
…s and Temporal object See tc39/proposal-temporal#2795. When attempting to format a Temporal object, if the DateTimeFormat has options that do not overlap with the data model of the Temporal object, toLocaleString() and format() are supposed to throw a TypeError.
Ms2ger
force-pushed
the
temporal-coverage
branch
from
304e7a5
to
96b5194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit.
cc @anba