Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructuring Binding - syntax and simple initialization #460

Merged
merged 2 commits into from
Jan 14, 2016

Conversation

leobalter
Copy link
Member

I believe at least the minimal tests for syntax is ready, but there's a lot of other tests to bring to this PR.

Possibly coming up next week:

  • complete tests for ObjectBindingPattern initilization (13.3.3.5)
  • ArrayBindingPattern initialization (IteratorBindingInitialization 13.3.3.6)
  • KeyedBindingInitialization (13.3.3.7)
  • BindingPattern statements
  • Function length based on parameters list (13.3.3.4)

Extra, maybe not necessary for this coverage goal:

  • check tests for BoundNames
  • destructuring binding on variable declarations
  • ForDeclaration/ForBinding
  • CatchParameter

@leobalter
Copy link
Member Author

I'm gonna stop this PR from where it is and wait for #467.

This PR only covers the syntax for Destructuring Binding on function parameters, it's missing coverage for other forms as statements, variable declarations, for, catch, etc. which might produce a lot of repetitive code which is way easier to target after #467 is solved.

The initialization tests should also consider this repetitive syntax work.

Said that, I believe we can stick with the current tests as an introductory phase, even as a parameter to support on the other syntax forms.

@goyakin
Copy link
Member

goyakin commented Jan 13, 2016

@leobalter, these tests look good to me. If you want, I can merge them in now rather than waiting for #467. We can refactor the tests later.

@leobalter
Copy link
Member Author

@goyakin Thanks! I agree it's good to merge now and refactor later.

goyakin pushed a commit that referenced this pull request Jan 14, 2016
Destructuring Binding - syntax and simple initialization
@goyakin goyakin merged commit c9764dc into tc39:master Jan 14, 2016
@leobalter
Copy link
Member Author

Thanks!

@leobalter leobalter deleted the destructuring-binding branch January 14, 2016 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants