Add tests for destructuring binding (procedurally generated) #584
Conversation
jugglinmike
changed the title
| //- vals | ||
| iter | ||
| //- body | ||
| assert.sameValue(doneCallCount, 1); |
There was a problem hiding this comment.
can we use any message on these?
On the arrow-function example there's another assertion with the same expected value (assert.sameValue(callCount, 1);) and a message would be very helpful to identify the assertion if it fails.
There was a problem hiding this comment.
That's a good idea!
|
Now that gh-601 has landed (thanks @leobalter and @goyakin), the generated |
|
@jugglinmike would you help with the rebase, please? |
Add test templates for destructuring binding as it occurs in previously-overlooked productions (various IterationStatements and the TryStatement).
jugglinmike
force-pushed
the
generation-dstr-bndng
branch
from
240f1d6
to
d4b263c
Compare
|
Sure; I have rebased this branch as I suggested above |
|
I merged it intentionally with a merge commit as I didn't want to squash the generated tests. Great work, Mike! |
Although the bulk of the work here is in new test cases, this change set
includes two updates to previously-accepted files:
esidfrontmatter tag (which was designed in the time since thefiles were first written)
identify)
To help facilitate review, I've organized all procedurally-generated changes
into dedicated commits.