Test that Date.prototype.toString throws for non-Date receiver #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending discussion of tc39/ecma262#849 Test passes in V8.
leobalter
suggested changes
Mar 21, 2017
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| esid: #sec-date.prototype.tostring |
There was a problem hiding this comment.
we need to remove the # here.
| @@ -0,0 +1,12 @@ | |||
| // Copyright (C) 2017 V8 project authors. All rights reserved. | |||
There was a problem hiding this comment.
nitpick for consistency: the V8 project authors
- // Copyright (C) 2017 V8 project authors. All rights reserved.
+ // Copyright (C) 2017 the V8 project authors. All rights reserved.| /*--- | ||
| esid: #sec-date.prototype.tostring | ||
| description: Date.prototype.toString throws a TypeError on non-Date receivers | ||
| ---*/ |
There was a problem hiding this comment.
The info tag is being valuable for reviews (even after the PR phase). If you don't mind, I would like to add the following:
+info: |
+ Date.prototype.toString ( )
+
+ 1. Let tv be ? thisTimeValue(this value).| description: Date.prototype.toString throws a TypeError on non-Date receivers | ||
| ---*/ | ||
|
|
||
| assert.throws(TypeError, () => Date.prototype.toString()); |
There was a problem hiding this comment.
good catch! I hope we never give Date.prototype a [[DateValue]] internal slot anymore, even worse with a NaN value.
There was a problem hiding this comment.
Interestingly, this is the only case that ChakraCore fails.
| assert.throws(TypeError, () => Date.prototype.toString()); | ||
| assert.throws(TypeError, () => Date.prototype.toString.call(undefined)); | ||
| assert.throws(TypeError, () => Date.prototype.toString.call(0)); | ||
| assert.throws(TypeError, () => Date.prototype.toString.call({})); |
There was a problem hiding this comment.
I would like to suggest 2 special cases we can add in here:
Date.prototype.toString.call("Tue Mar 21 2017 12:16:43 GMT-0400 (EDT)")
Date.prototype.toString.call(1490113011493)It seems silly but they're still parseable values.
leobalter
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending discussion of tc39/ecma262#849. Not ready to merge yet!
Test passes in V8.