Date toString tests #930
Merged
Date toString tests #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the proposed specification in tc39/ecma262#848
leobalter
previously requested changes
May 23, 2017
| assert.notSameValue(null, match); | ||
|
|
||
| // Years are padded to the left with zeroes | ||
| match = stringRegExp.exec(new Date('0020-01-01T00:00:00Z').toDateString()); |
|
The spec change landed, but changes still needed on the test. |
|
With that typo fixed, the tests pass on a hacked version of V8 that implements the new specification, so I don't think there are any more obvious typos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests check the semantics of Date.prototype.toString, Date.prototype.toTimeString,
Date.prototype.toDateString and Date.prototype.toUTCString. There are probably ways
to make the more specific, but this is a start. The semantics are currently implementation-defined,
but a spec pull request at tc39/ecma262#848 gives them this behavior.