Used safe arithmetic in sum() and product()

...at least when using integral types.
tcbrindle · Aug 28, 2024 · 5996620 · 5996620
1 parent 5d2dce5
commit 5996620
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/include/flux/op/fold.hpp b/include/flux/op/fold.hpp
@@ -65,7 +65,11 @@ struct sum_op {
     [[nodiscard]]
     constexpr auto operator()(Seq&& seq) const -> value_t<Seq>
     {
-        return fold_op{}(FLUX_FWD(seq), std::plus<>{}, value_t<Seq>(0));
+        if constexpr (num::integral<value_t<Seq>>) {
+            return fold_op{}(FLUX_FWD(seq), num::add, value_t<Seq>(0));
+        } else {
+            return fold_op{}(FLUX_FWD(seq), std::plus<>{}, value_t<Seq>(0));
+        }
     }
 };
 
@@ -76,7 +80,11 @@ struct product_op {
     [[nodiscard]]
     constexpr auto operator()(Seq&& seq) const -> value_t<Seq>
     {
-        return fold_op{}(FLUX_FWD(seq), std::multiplies<>{}, value_t<Seq>(1));
+        if constexpr (num::integral<value_t<Seq>>) {
+            return fold_op{}(FLUX_FWD(seq), num::mul, value_t<Seq>(1));
+        } else {
+            return fold_op{}(FLUX_FWD(seq), std::multiplies<>{}, value_t<Seq>(1));
+        }
     }
 };