Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overflow in cartesian_product size() impl #168

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

tcbrindle
Copy link
Owner

Fixes #167

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6610792) 98.06% compared to head (b4c244d) 98.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          69       69           
  Lines        2424     2426    +2     
=======================================
+ Hits         2377     2379    +2     
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcbrindle
Copy link
Owner Author

Thanks for the review @isaacy2012 👍

@tcbrindle tcbrindle merged commit 5900bb8 into main Feb 3, 2024
31 checks passed
@tcbrindle tcbrindle deleted the pr/cartesian_size_fix branch June 3, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cartesian_product size() can overflow
2 participants