Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation #170

Merged
merged 1 commit into from
Feb 11, 2024
Merged

fix: documentation #170

merged 1 commit into from
Feb 11, 2024

Conversation

goto40
Copy link
Contributor

@goto40 goto40 commented Feb 11, 2024

Great CppCon talk!

I found a minor bug in the documentation: the sum(5) yields 40 not 12 - I fixed this and added some comments.
Maybe you already fixed this somewhere - in this case just discard this change.

Somehow my auto-formatter also added some spaces (I can rework the PR if you prefer the original formatting).

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22d87d8) 98.06% compared to head (1f44724) 98.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          69       69           
  Lines        2426     2426           
=======================================
  Hits         2379     2379           
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcbrindle
Copy link
Owner

Oh dear, that's a bit embarrassing for the first example people see! Thanks for spotting it.

@tcbrindle tcbrindle merged commit 0cc3120 into tcbrindle:main Feb 11, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants