Attempt to work around Clang 18 ICE #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 69 69
Lines 2426 2426
=======================================
Hits 2379 2379
Misses 47 47 ☔ View full report in Codecov by Sentry. |
This is a wild stab in the dark which attempts to solve the Clang 18 internal compiler error reported in #174. Homebrew doesn't have LLVM 18 yet so I don't have a local install of the latest Clang, and we can't add it to CI either. This PR just slightly simplifies the code that Clang appears to dislike (based on the backtrace supplies in #174), but unfortunately I don't have any way of testing it yet. So let's see what happens...
tcbrindle
force-pushed
the
pr/fix_clang18_ice
branch
from
e9bd95b
to
89ab64c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wild stab in the dark which attempts to solve the Clang 18 internal compiler error reported in #174.
Homebrew doesn't have LLVM 18 yet (Homebrew/homebrew-core#165206) so I don't have a local install of the latest Clang, and we can't add it to CI either. This PR just slightly simplifies the code that Clang appears to dislike (based on the backtrace supplies in #174), but unfortunately I don't have any way of testing it yet.
So let's see what happens...