Test reorg #358
Merged
Test reorg #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaltyDavidselph
force-pushed
the
test-reorg
branch
from
73735d2
to
e7853dc
Compare
eeeebbbbrrrr
previously requested changes
Aug 2, 2023
There was a problem hiding this comment.
@SaltyDavidselph overall this looks good. The only thing is I don't want this PR to change the pgrx version PL/Rust currently uses. So please set them all back to 0.9.7.
Once that's done and we confirm CI still works we can merge this.
plrust-tests/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| pgrx = "=0.9.7" | ||
| tempdir = "0.3.7" |
There was a problem hiding this comment.
Suggested change
| tempdir = "0.3.7" | |
| tempfile = "0.3.8" |
There was a problem hiding this comment.
Oh, this was the wrong suggestion. I'm silly.
The new `plrust-tests` create is a standalone pgrx crate that only contains the unit tests from `plrust`. These were copied over verbatim. To run the tests: ```shell $ cd plrust-tests $ ./run-tests.sh pgXX [test_name] ```
each new rs covers an area of test
…t-tests run-tests.sh
workingjubilee
force-pushed
the
test-reorg
branch
from
0a86c5e
to
5762750
Compare
|
Rebased and pulled out the additional test added by #373. |
|
Somehow pulling out the test broke it, so I am going to leave that for a later PR to examine, this one has been waiting long enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.