Use system entropy to initialize hashmap keys #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if we need this. It's an annoying amount of code because we can't really use the
unix/rand.rs
implementation (and don't have any remaining file I/O code elsewhere). See comment for details.That said, this should avoid HashDOS, but I'm unsure if that was plausible anyway without this change. ISTM most of the time we'll still ensure a unique seed due to the per-use increment in RandomState, and I think SipHash is strong enough that per-use unique seeds are sufficient to avoid the issue unless the attacker can (probabilistically) guarantee that they're the first caller of that function. That's unlikely but not so unlikely that it seems ignorable...
I've opted to panic on failure (the way the stdlib does) rather than fall back to insecure behavior, since if there's a benefit to having it, it seems bad to allow it to fail silently.
Any thoughts @workingjubilee?