Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Commit

Permalink
Merge commit '9a58eac616437ccc67dfce105add1445b8bf29e5' into develop
Browse files Browse the repository at this point in the history
# Conflicts:
#	build.gradle
#	vector/build.gradle
#	vector/libs/matrix-sdk.aar
#	vector/src/main/AndroidManifest.xml
#	vector/src/main/assets/open_source_licenses.html
#	vector/src/main/java/im/vector/Matrix.java
#	vector/src/main/java/im/vector/VectorApp.java
#	vector/src/main/java/im/vector/activity/CommonActivityUtils.java
#	vector/src/main/java/im/vector/activity/FallbackLoginActivity.java
#	vector/src/main/java/im/vector/activity/LoginActivity.java
#	vector/src/main/java/im/vector/activity/RiotAppCompatActivity.kt
#	vector/src/main/java/im/vector/activity/SplashActivity.java
#	vector/src/main/java/im/vector/activity/VectorHomeActivity.java
#	vector/src/main/java/im/vector/activity/VectorMediasPickerActivity.java
#	vector/src/main/java/im/vector/activity/VectorMemberDetailsActivity.java
#	vector/src/main/java/im/vector/activity/VectorRoomActivity.java
#	vector/src/main/java/im/vector/activity/VectorRoomCreationActivity.java
#	vector/src/main/java/im/vector/activity/VectorRoomDetailsActivity.java
#	vector/src/main/java/im/vector/activity/VectorRoomInviteMembersActivity.java
#	vector/src/main/java/im/vector/activity/VectorSettingsActivity.java
#	vector/src/main/java/im/vector/activity/VectorSharedFilesActivity.java
#	vector/src/main/java/im/vector/adapters/AdapterSection.java
#	vector/src/main/java/im/vector/adapters/VectorMediasViewerAdapter.java
#	vector/src/main/java/im/vector/adapters/VectorMessagesAdapter.java
#	vector/src/main/java/im/vector/adapters/VectorParticipantsAdapter.java
#	vector/src/main/java/im/vector/adapters/VectorRoomDetailsMembersAdapter.java
#	vector/src/main/java/im/vector/adapters/VectorRoomSummaryAdapter.java
#	vector/src/main/java/im/vector/adapters/VectorSearchFilesListAdapter.java
#	vector/src/main/java/im/vector/adapters/VectorSearchMessagesListAdapter.java
#	vector/src/main/java/im/vector/fragments/AbsHomeFragment.java
#	vector/src/main/java/im/vector/fragments/HomeFragment.java
#	vector/src/main/java/im/vector/fragments/PeopleFragment.java
#	vector/src/main/java/im/vector/fragments/RoomsFragment.java
#	vector/src/main/java/im/vector/fragments/VectorMessageListFragment.java
#	vector/src/main/java/im/vector/fragments/VectorRecentsListFragment.java
#	vector/src/main/java/im/vector/fragments/VectorRoomDetailsMembersFragment.java
#	vector/src/main/java/im/vector/fragments/VectorRoomSettingsFragment.java
#	vector/src/main/java/im/vector/fragments/VectorSearchRoomsFilesListFragment.java
#	vector/src/main/java/im/vector/fragments/VectorSettingsPreferencesFragment.java
#	vector/src/main/java/im/vector/receiver/VectorRegistrationReceiver.java
#	vector/src/main/java/im/vector/util/PreferencesManager.java
#	vector/src/main/java/im/vector/util/RageShake.java
#	vector/src/main/java/im/vector/util/RoomUtils.java
#	vector/src/main/java/im/vector/util/SlashCommandsParser.java
#	vector/src/main/java/im/vector/util/ThemeUtils.java
#	vector/src/main/java/im/vector/util/VectorUtils.java
#	vector/src/main/res/drawable-hdpi/message_notification_transparent.png
#	vector/src/main/res/drawable-hdpi/permanent_notification_transparent.png
#	vector/src/main/res/drawable-mdpi/message_notification_transparent.png
#	vector/src/main/res/drawable-mdpi/permanent_notification_transparent.png
#	vector/src/main/res/drawable-xhdpi/message_notification_transparent.png
#	vector/src/main/res/drawable-xhdpi/permanent_notification_transparent.png
#	vector/src/main/res/drawable-xxhdpi/logo_transparent.png
#	vector/src/main/res/drawable-xxhdpi/message_notification_transparent.png
#	vector/src/main/res/drawable-xxhdpi/permanent_notification_transparent.png
#	vector/src/main/res/drawable-xxxhdpi/message_notification_transparent.png
#	vector/src/main/res/drawable-xxxhdpi/permanent_notification_transparent.png
#	vector/src/main/res/layout/activity_home.xml
#	vector/src/main/res/layout/activity_vector_login.xml
#	vector/src/main/res/layout/activity_vector_medias_picker.xml
#	vector/src/main/res/layout/activity_vector_registration_captcha.xml
#	vector/src/main/res/layout/activity_vector_room.xml
#	vector/src/main/res/layout/adapter_item_vector_add_participants.xml
#	vector/src/main/res/layout/vector_activity_splash.xml
#	vector/src/main/res/layout/vector_home_menu_header.xml
#	vector/src/main/res/menu/vector_home_sliding_menu.xml
#	vector/src/main/res/values-fr/strings.xml
#	vector/src/main/res/values/colors.xml
#	vector/src/main/res/values/strings.xml
#	vector/src/main/res/xml/vector_room_settings_preferences.xml
#	vector/src/main/res/xml/vector_settings_preferences.xml
  • Loading branch information
giomfo committed Aug 25, 2018
2 parents adab2b9 + 9a58eac commit d1fb2d8
Show file tree
Hide file tree
Showing 326 changed files with 18,084 additions and 12,589 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@

.gradle
/local.properties

/tmp
5 changes: 4 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,7 @@ before_script:
- /bin/sh ./set_debug_env.sh

# Just build the project for now
script: ./gradlew clean lintAppRelease assembleAppRelease --stacktrace
script:
- ./gradlew clean lintAppRelease assembleAppRelease --stacktrace
- ./tools/check/check_code_quality.sh
- ./tools/travis/check_pr.sh
6 changes: 6 additions & 0 deletions AUTHORS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,9 @@ Chris Tarazi <tarazichris at gmail.com>

Safa AlFulaij <safa1996alfulaij at gmail.com>
* PR #1934: Fix some plural messages.

Isa Cichon <isa4 at posteo.net>
* Add spacing to device keys

Nathan van Beelen <nathan at vanbeelen.org>
* PR #1742: Add a media previewer
95 changes: 93 additions & 2 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,18 +1,109 @@
Changes in Riot 0.8.11 (2018-XX-XX)
Changes in Riot 0.8.14 (2018-XX-XX)
===================================================

Features:
-

Improvements:
-
- Do not ask permission to write external storage at startup (#2483)
- Update settings icon and transparent logo for notifications and navigation drawer (#2492)
- URL previews are no longer requested from the server when displaying URL previews is disabled (PR #2514)
- Fix some plural and puzzle strings, and remove other unused ones (#2444)

Other changes:
- Upgrade olm-sdk.aar from version 2.2.2 to version 2.3.0
- move PieFractionView from the SDK to the client (#2525)

Bugfix:
-

Translations:
-

Build:
-

Changes in Riot 0.8.13 (2018-08-09)
===================================================

Features:
- Resurrect performance metrics (#2391)
- Telemetry to report incidence of UISIs (#2330)
- Add a previewer for previewing media before sending it into the room (#1742|#2445)
- Implements ReplyTo feature (#2390)
- Add auto completion for slash commands (#2384)
- Support Room Versioning (#2441)

Improvements:
- Update matrix-sdk.aar lib (v0.9.7).
- Piwik: Update the way how stats are reported (#2402)
- Improve BugReport screen: display a preview of the screenshot (#2318)
- In the settings, move theme settings just below "language" (#2439)
- Improve the display of the sources of the message in the dialog (#2348)
- Improve the display of the buttons and the reason in the room preview (#2352)
- In the flair section on settings, notify the user when he has no flair (#2430)
- Improve GDPR consent webview management (#2491)
- Support external keyboard to send messages for recent devices (#220, #1279)
- When user ignores or un-ignores someone, notify that the app will restart (#2437)

Other changes:
- Remove dependency to `android-gif-drawable` lib and use Glide to animate logo on Splashscreen (#2421)
- Keep only Room.getState() method and remove Room.getLiveState() because they are similar (matrix-org/matrix-android-sdk#310)

Bugfix:
- Fix issue on incoming call screen when "Do not disturb mode" is active (#2417)
- Fix issue when selecting sound for notifications in the settings
- Fix issue when changing device name in the settings (#2416)
- Fix issue on verifying device, update the wording of the description message (#1067)
- Messages with code blocks show other HTML as plain text (#2280)
- Message with <p> was sometimes not properly formatted (#2275)
- Fix notification issue when Riot is not started (#2451)
- Fix Unable to add Matrix apps (#2466)
- Riot auto joined a public room (#2472)
- Remove last traces of Firebase analytics (#2481)
- code blocks are escaped and therefore hard readable (#2484)
- Restore the navigation of the back button in the public rooms preview header (#2473)
- Fix issue on preference screen: device lists was not displayed (#2409)
- Ensure notification has a title (#2242)

Changes in Riot 0.8.12 (2018-07-06)
===================================================

Bugfix:
- Fix issue on vanished favorite and low priority room (#2413)

Changes in Riot 0.8.11 (2018-07-03)
===================================================

Features:
- Re-request keys manually for encrypted events (#2319)
- Add option to send voice message to a room, using a third application to record message.
To enable in the Labs settings (PR #1762)

Improvements:
- Update matrix-sdk.aar lib (v0.9.6).
- New Floating Action Menu in Home screen (PR #2335)
- Add spacing to device keys (#2314)
- use apply() instead of commit() to save shared prefs (#2231)
- Do not ring if "Do Not Disturb" is active (#1072)
- Manage the "consent not given" error when declining a room invite

Other changes:
- Remove "Matrix application" activation from the Lab section in the settings (#2341)

Bugfix:
- Remove black borders on 18:9 phone (#2063)
- Auto dismiss the join/reject room notification when user select an action (#2354)
- Fix some crashes reported by the PlayStore (#2380, #2382, #2383, #2395)
- Fix issues in UrlPreviews (#2312)

Translations:
- Galician thanks to Miguel Branco

Build:
- Add script to check code quality
- Travis will now check if CHANGES.rst has been modified for each PR

Changes in Riot 0.8.10 (2018-01-06)
===================================================

Expand Down
10 changes: 8 additions & 2 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ use github's pull request workflow to review the contribution, and either ask
you to make any refinements needed or merge it and make them ourselves. The
changes will then land on master when we next do a release.

We use Jenkins for continuous integration (http://matrix.org/jenkins), and
typically all pull requests get automatically tested Jenkins: if your change breaks the build, Jenkins will yell about it in #matrix-dev:matrix.org so please lurk there and keep an eye open.
All pull requests are built by TravisCI. Please fix any issue found by TravisCI
on your PR

Code style
~~~~~~~~~~
Expand All @@ -54,6 +54,12 @@ description of the area(s) you've worked on. Also, we sometimes have swag to
give away to contributors - if you feel that Matrix-branded apparel is missing
from your life, please mail us your shipping address to matrix at matrix.org and we'll try to fix it :)

Changelog
~~~~~~~~~

Please add at least one line on the top of file CHANGES.rst (in the correct section)
to describe what you've done on the code (bugfix, new feature, etc.)

Sign off
~~~~~~~~

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Riot
Riot-Android [![Jenkins](https://img.shields.io/jenkins/s/https/matrix.org/jenkins/view/MatrixView/job/VectorAndroidDevelop.svg)](https://matrix.org/jenkins/view/MatrixView/job/VectorAndroidDevelop/) [![Weblate](https://translate.riot.im/widgets/riot-android/-/svg-badge.svg)](https://translate.riot.im/engage/riot-android/?utm_source=widget)
=======

Riot is an Android Matrix client.
Expand Down
2 changes: 1 addition & 1 deletion build_matrix_sdk_lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ echo remove sdk folder
rm -rf matrix-android-sdk

echo clone the git folder
git clone -b master https://github.com/matrix-org/matrix-android-sdk
git clone -b master https://github.com/matrix-org/matrix-android-sdk

cd matrix-android-sdk

Expand Down
26 changes: 26 additions & 0 deletions build_matrix_sdk_lib_develop.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
#!/bin/bash

echo "Save current dir"
currentDir=`pwd`

echo "up dir"
cd ..

echo "remove sdk folder"
rm -rf matrix-android-sdk

echo "clone the matrix-android-sdk repository, and checkout develop branch"
git clone -b develop https://github.com/matrix-org/matrix-android-sdk

cd matrix-android-sdk

echo "Build matrix sdk from source"
./gradlew clean assembleRelease

cd ${currentDir}

echo "Copy freshly built matrix sdk to the libs folder"
# Ensure the lib is updated by removing the previous one
rm vector/libs/matrix-sdk.aar

cp ../matrix-android-sdk/matrix-sdk/build/outputs/aar/matrix-sdk-release-*.aar vector/libs/matrix-sdk.aar
152 changes: 152 additions & 0 deletions tools/check/check_code_quality.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
#!/usr/bin/env bash

#
# Copyright 2018 New Vector Ltd
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

#######################################################################################################################
# Check drawable quantity
#######################################################################################################################

echo "Check drawable quantity"

numberOfFiles1=`ls -1U ./vector/src/main/res/drawable-hdpi | wc -l | sed "s/ //g"`
numberOfFiles2=`ls -1U ./vector/src/main/res/drawable-mdpi | wc -l | sed "s/ //g"`
numberOfFiles3=`ls -1U ./vector/src/main/res/drawable-xhdpi | wc -l | sed "s/ //g"`
numberOfFiles4=`ls -1U ./vector/src/main/res/drawable-xxhdpi | wc -l | sed "s/ //g"`
numberOfFiles5=`ls -1U ./vector/src/main/res/drawable-xxxhdpi | wc -l | sed "s/ //g"`

if [ ${numberOfFiles1} -eq ${numberOfFiles5} ] && [ ${numberOfFiles2} -eq ${numberOfFiles5} ] && [ ${numberOfFiles3} -eq ${numberOfFiles5} ] && [ ${numberOfFiles4} -eq ${numberOfFiles5} ]; then
resultNbOfDrawable=0
echo "OK"
else
resultNbOfDrawable=1
# DISABLE for the moment
resultNbOfDrawable=0
echo "ERROR, missing drawable alternative."
fi

echo

#######################################################################################################################
# Search forbidden pattern
#######################################################################################################################

searchForbiddenStringsScript=./tmp/search_forbidden_strings.pl

if [ -f ${searchForbiddenStringsScript} ]; then
echo "${searchForbiddenStringsScript} already there"
else
mkdir tmp
echo "Get the script"
wget https://raw.githubusercontent.com/matrix-org/matrix-dev-tools/develop/bin/search_forbidden_strings.pl -O ${searchForbiddenStringsScript}
fi

if [ -x ${searchForbiddenStringsScript} ]; then
echo "${searchForbiddenStringsScript} is already executable"
else
echo "Make the script executable"
chmod u+x ${searchForbiddenStringsScript}
fi

echo
echo "Search for forbidden patterns in code..."

${searchForbiddenStringsScript} ./tools/check/forbidden_strings_in_code.txt \
./vector/src/app/java \
./vector/src/appfdroid/java \
./vector/src/main/java

resultForbiddenStringInCode=$?

echo
echo "Search for forbidden patterns in resources..."

${searchForbiddenStringsScript} ./tools/check/forbidden_strings_in_resources.txt \
./vector/src/main/res/anim \
./vector/src/main/res/color \
./vector/src/main/res/menu \
./vector/src/main/res/layout \
./vector/src/main/res/values \
./vector/src/main/res/values-v21 \
./vector/src/main/res/values-w820dp \
./vector/src/main/res/xml

resultForbiddenStringInResource=$?

#######################################################################################################################
# Check files with long lines
#######################################################################################################################

checkLongFilesScript=./tmp/check_long_files.pl

if [ -f ${checkLongFilesScript} ]; then
echo "${checkLongFilesScript} already there"
else
mkdir tmp
echo "Get the script"
wget https://raw.githubusercontent.com/matrix-org/matrix-dev-tools/develop/bin/check_long_files.pl -O ${checkLongFilesScript}
fi

if [ -x ${checkLongFilesScript} ]; then
echo "${checkLongFilesScript} is already executable"
else
echo "Make the script executable"
chmod u+x ${checkLongFilesScript}
fi

echo
echo "Search for long files..."

# TODO Decrease this limit in a near future...
${checkLongFilesScript} 4100 \
./vector/src/app/java \
./vector/src/appfdroid/java \
./vector/src/main/java \
./vector/src/main/res/layout \
./vector/src/main/res/menu \
./vector/src/main/res/values \
./vector/src/main/res/values-v21 \
./vector/src/main/res/values-w820dp

resultLongFiles=$?

#######################################################################################################################
# search png in drawable folder
#######################################################################################################################

echo
echo "Search for png files in /drawable..."

ls -1U ./vector/src/main/res/drawable/*.png
resultTmp=$?

# Inverse the result, cause no file found is an error for ls but this is what we want!
if [ ${resultTmp} -eq 0 ]; then
echo "ERROR, png files detected in /drawable"
resultPngInDrawable=1
else
echo "OK"
resultPngInDrawable=0
fi

echo

if [ ${resultNbOfDrawable} -eq 0 ] && [ ${resultForbiddenStringInCode} -eq 0 ] && [ ${resultForbiddenStringInResource} -eq 0 ] && [ ${resultLongFiles} -eq 0 ] && [ ${resultPngInDrawable} -eq 0 ]; then
echo "MAIN OK"
else
echo "MAIN ERROR"
exit 1
fi
Loading

0 comments on commit d1fb2d8

Please sign in to comment.