This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Add tagged SHA-256 hash module #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
05-13-tagged
branch
3 times, most recently
from
e90c964
to
a2f5b0f
Compare
We do not need a variable for `$hash` in the `hash_trait_imlps`. This patch reverts back to how this was in `rust-bitcoin` sans the generics. Refactor only, no logic changes.
Turns out we do need generics on the `hash_trait_impls` macro. This patch reverts back to how this was in `rust-bitcoin` sans the generics.
The `AsRef<[u8]` trait better describes the functionality we are trying to provide - a reference to the underlying byte array.
Import the `sha256t` type from `rust-bitcoin` excluding the macro `sha256t_hash_newtype.` Patch the imported code to fit in with the current design of this crate, requires: - Add inherent methods instead of using the `Hash` trait. - Mimic API of other hash types.
Currently the `sha256t` module uses an alias to the `sha256::HashEngine`, this is a footgun because if a user accidentally uses the `sha256t` module the same way as the other hash modules they will get the wrong engine. For example this code looks fine but is buggy (it does not pre-tag the engine): ``` let mut engine = sha256t::HashEngine::new(); // Or `default()`. engine.input(some_data); let hash = engine.finalize(); ``` We can fix the situation by adding a `HashEngine<T>` type to the `sha256t` module and implementing `Default` for it by calling the `Tag::engine` function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bitcoin_hashesmodule supports domain separation by way of thesha256tmodule, this crate currently does not - that is a regression.Introduce tagged SHA-256 hashes. First import the code from
rust-bitcointhen add the tag to the engine as well as theHash.