-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ID-based links #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am aware it is WIP, but I thought some things could be improved.
Co-authored-by: Tomasz Czajęcki <tomek.czajecki@gmail.com>
b8cac89
to
9035e6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last batch of requests.
BTW, please remove package-lock.json
. The extension will be published with yarn
-downloaded dependencies anyway, so it only creates a confusion with two of those files. Especially that I won't be using it so the contents will quickly get outdated.
Did not take into account file ids.
- as the default value use \d{14} which is also the default in Zettlr - adjust ids in wiki-links examples to match this expression
Co-authored-by: Tomasz Czajęcki <tomek.czajecki@gmail.com>
This allows usage of ^ and $ to match line start and end.
Implement functionality inspired by Zettlr -- the ability to store ids in files and link to them with wiki-style links. For example:
The file id is the first match of a (configurable) regex in its contents.