This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
Remove extraneous params from subsequent query requests #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #100. I've got it running in my Home Assistant instance and it has fixed the issue for me. That said I only have the Arlo Baby to test with - anyone else able to test out this fix would be greatly appreciated. |
|
Working fine here for my 3x Arlo Pro 2 and the base station. The modes are retrieved correctly. LGTM. |
|
@tchellomello based on the feedback here and on home-assistant/core#17427 this appears to fix the issue without negative side effects. Can I get a code review and a bump/publish to PyPi? |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usernameandpasswordparams from being included on each request.