Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Fix errors for cameras without ambient sensors #94

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

lukiffer
Copy link
Collaborator

Fix a reference error when None is returned from the API when querying ambient sensor data. See home-assistant/core#15486

@coveralls
Copy link

coveralls commented Jul 16, 2018

Coverage Status

Coverage increased (+0.05%) to 78.868% when pulling b0ad6a2 on lukiffer:fix/15486 into 918cdee on tchellomello:master.

@lukiffer lukiffer changed the title Fix errors for cameras without ambient sensors WIP Fix errors for cameras without ambient sensors Jul 16, 2018
@lukiffer lukiffer changed the title WIP Fix errors for cameras without ambient sensors Fix errors for cameras without ambient sensors Jul 16, 2018
@lukiffer
Copy link
Collaborator Author

@tchellomello did the linter rules get stricter recently? There's some linter errors that can be corrected but will break python2 compatibility/portability. Otherwise, this PR should be good to. Trying to get this into Home Assistant 0.74.0b1. Cheers!

@tchellomello
Copy link
Owner

@lukiffer that is because the linter is not pinned in the requirements_tests.txt so if the linter gets a new policy, it will be inherent by us.

Copy link
Owner

@tchellomello tchellomello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! Good job! 👍

@tchellomello tchellomello merged commit da92f39 into tchellomello:master Jul 17, 2018
@tchellomello
Copy link
Owner

@lukiffer I'm going to publish a new version tonight for you. Give some minutes.

@tchellomello tchellomello mentioned this pull request Jul 17, 2018
@lukiffer lukiffer deleted the fix/15486 branch July 17, 2018 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants