feat(auth): add default value for github api and update doc (#1779)

Fix #1775
tchiotludo · May 21, 2024 · f9968fc · f9968fc
1 parent e5458e9
commit f9968fc
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/docs/docs/configuration/authentifications/github.md b/docs/docs/configuration/authentifications/github.md
@@ -22,6 +22,12 @@ micronaut:
             auth-method: client-secret-post
 ```
 
+You can also override the GitHub API url if needed. Default value is https://api.github.com
+
+```yaml
+github.api.url: https://override.api.github.com
+```
+
 To further tell AKHQ to display GitHub SSO options on the login page and customize claim mapping, configure Oauth in the AKHQ config:
 
 ```yaml

diff --git a/src/main/java/org/akhq/security/authentication/GithubApiClient.java b/src/main/java/org/akhq/security/authentication/GithubApiClient.java
@@ -8,7 +8,7 @@
 
 @Header(name = "User-Agent", value = "Micronaut")
 @Header(name = "Accept", value = "application/vnd.github.v3+json, application/json")
-@Client("${github.api.url}")
+@Client("${github.api.url:`https://api.github.com`}")
 public interface GithubApiClient {
 
     @Get("/user")

diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml
@@ -71,7 +71,7 @@ micronaut:
   http:
     client:
       allow-block-event-loop: true
-      github.api.url: https://api.github.com
+
 
 jackson:
   serialization: