Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema registry doesn't URL encode subject name #1353

Closed
baganokodo2022 opened this issue Jan 24, 2023 · 5 comments
Closed

schema registry doesn't URL encode subject name #1353

baganokodo2022 opened this issue Jan 24, 2023 · 5 comments
Labels
bug Something isn't working registry Kafka Schema Registry

Comments

@baganokodo2022
Copy link
Contributor

Hi team,

I found an issue in the Schema Registry view on those imported Protobuf schemas, which typically have forward slash in the subject name, as shown in the screen shot. We need to URL encode these subject names, otherwise, clicking on the subject will take you back to the topic view.

Cheers
Screenshot 2023-01-24 at 2 16 31 PM

@tchiotludo
Copy link
Owner

seems to be the same issue than this one from consumer groups: #1184
PR are welcome 👍

@tchiotludo tchiotludo added bug Something isn't working registry Kafka Schema Registry labels Jan 24, 2023
@baganokodo2022
Copy link
Contributor Author

I have the fix working locally, will submit a PR today.

@baganokodo2022
Copy link
Contributor Author

HI @tchiotludo ,

With I push my branch, I saw the following error, would you grant me permission to git push?
$ git push origin xinyuliu/fix-issues-1353

ERROR: Permission to tchiotludo/akhq.git denied to baganokodo2022.
fatal: Could not read from remote repository.

thank you

@tchiotludo
Copy link
Owner

you need to create a fork and create a pull request

@baganokodo2022
Copy link
Contributor Author

baganokodo2022 commented Jan 25, 2023

Hi @tchiotludo

Here is the PR #1354, please review.

thank you for bring us such a powerful and comprehensive Kafka tool.

Xinyu Liu

tchiotludo pushed a commit that referenced this issue Apr 4, 2023
close #1353

Co-authored-by: xinyu.liu <xinyu.liu@coinbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working registry Kafka Schema Registry
Projects
Status: Done
Development

No branches or pull requests

2 participants