Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to delete topic config #362

Closed
piotrp opened this issue Aug 18, 2020 · 1 comment · Fixed by #1602
Closed

Allow to delete topic config #362

piotrp opened this issue Aug 18, 2020 · 1 comment · Fixed by #1602
Labels
enhancement New feature or request good first issue Good for newcomers node Kafka Node topic Kafka Topic Config ui Need an ui update

Comments

@piotrp
Copy link
Contributor

piotrp commented Aug 18, 2020

Currently there is no way to remove topic config and restore its displayed type to DEFAULT_CONFIG. It should be possible eg. by leaving text input empty.

My use case: clearing topic by setting retention.ms, i.e.:

  1. Set retention.ms to 1
  2. Wait
  3. Delete retention.ms override

In most cases I don't want to store retention.ms in topic config because I want to use my cluster's default value.
@tchiotludo tchiotludo added enhancement New feature or request node Kafka Node topic Kafka Topic Config ui Need an ui update labels Aug 19, 2020
@tchiotludo tchiotludo added the good first issue Good for newcomers label Aug 19, 2020
@tchiotludo
Copy link
Owner

Good feature ;)
To be honest, I also use the same trick for now 😆

timonback pushed a commit to jnnfrmeyer/akhq that referenced this issue Oct 24, 2023
@jnnfrmeyer @timonback
feat(core): allow to delete topic config (tchiotludoGH-362)
4ffa4d2
timonback pushed a commit to jnnfrmeyer/akhq that referenced this issue Oct 24, 2023
@jnnfrmeyer @timonback
feat(core): allow to delete topic config (tchiotludoGH-362)
ea224f1 
Co-authored-by: peter.zahn@otto.de
Co-authored-by: fabian.besner@otto.de
Co-authored-by: timon.back@otto.de
timonback added a commit to jnnfrmeyer/akhq that referenced this issue Oct 24, 2023
@jnnfrmeyer @PeterZahn1994
@FabianBesner2020 @timonback
feat(core): allow to delete topic config (tchiotludoGH-362)
7e860b1 
Co-authored-by: Peter Zahn <peter.zahn@otto.de>
Co-authored-by: Fabian Besner <fabian.besner@otto.de>
Co-authored-by: Timon Back <timon.back@otto.de>
@timonback timonback mentioned this issue Oct 24, 2023
Merged
tchiotludo pushed a commit that referenced this issue Nov 19, 2023
@timonback
feat(topic): allow to delete topic config (#1602)
56a042f 
close #362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers node Kafka Node topic Kafka Topic Config ui Need an ui update
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): allow to delete topic config (GH-362) jnnfrmeyer/akhq
2 participants
@piotrp @tchiotludo