Uncheck all topics in consumer group update view by default. #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, just correct the checked that is wrong |
|
@tchiotludo thank you. When do you think a |
|
Not really soon, there is some hardwork in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when resetting offsets for a consumer group, all of the topics it subscribes to will be checked for the reset operation. This could be dangerous for a user that isn't paying attention and only trying to reset offsets for a particular topic. I propose we have all topics unchecked by default.
I also noticed that if you don't have any topics checked, and click
Update, the toast notification will show a success despite it not actually finishing behind the scenes. Adding a notification to give more clarity here.